exo-social

Jeremi, please attach your patch for our svn repo. It's a git patch.

Let me know if this one is working better.
Otherwise, I can commit it if the patch is good for you.

I just tried to build the whole project and find out this patch break a test:

• testPostToSpaceWithGlobalId(org.exoplatform.social.opensocial.spi.ExoActivityServiceTest)

It does so because I removed in SpaceIdentityProvider the parsing of the SpaceId.
Before the SpaceId was parsed at 2 places:

• SpaceIdentityProvider#findByRemoteId
• in the constructor of org.exoplatform.social.core.identity.model.GlobalId

So the spaceId was parsed 2 times in some cases instead of one which break the system if there is a colon character in the space name.

This need to be cleaned up and only one place should remain.

Are you sure this is a valid global id pattern:
<code>foo:bar:toto</code>
Its seems that this pattern does not meet global-id in OpenSocial spec: http://opensocial-resources.googlecode.com/svn/spec/1.0/Core-Data.xml#Global-Id

And what's the use case for that global id pattern? Does it makes thing complicated? And in global id, it should not contain space characters as in:
<code>id = new GlobalId("foo:Sugar: Case 4"); // valid</code>

Your patch has no problem. Please update code before committing, there are some changes in code affecting your patch.

Do you have a better solution?
I could remove the colon character, but it just look better with.

Also, did you see my comment http://jira.exoplatform.org/browse/SOC-937?focusedCommentId=56736&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_56736 ? For me this patch break a test testPostToSpaceWithGlobalId(org.exoplatform.social.opensocial.spi.ExoActivityServiceTest).